Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2166508: Setting page doesn't crash when the user doesn't have permission #1041

Conversation

DanaOrr
Copy link
Contributor

@DanaOrr DanaOrr commented Feb 9, 2023

Signed-off-by: Dana Orr dorr@redhat.com

📝 Description

🎥 Demo

Before:
image

After:
settingPageUserTest

Signed-off-by: Dana Orr <dorr@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2023

@DanaOrr: This pull request references Bugzilla bug 2166508, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.13.0) matches configured target release for branch (4.13.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2166508: Setting page doesn't crash when the user doesn't have permission

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gouyang February 9, 2023 10:00
@gouyang
Copy link
Member

gouyang commented Feb 9, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Feb 9, 2023
@metalice
Copy link
Member

metalice commented Feb 9, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DanaOrr, gouyang, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Feb 9, 2023
@openshift-merge-robot openshift-merge-robot merged commit 5e615a2 into kubevirt-ui:main Feb 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2023

@DanaOrr: All pull requests linked via external trackers have merged:

Bugzilla bug 2166508 has been moved to the MODIFIED state.

In response to this:

Bug 2166508: Setting page doesn't crash when the user doesn't have permission

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gouyang
Copy link
Member

gouyang commented Feb 22, 2023

/cherry-pick release-4.12

@openshift-cherrypick-robot
Copy link
Collaborator

@gouyang: new pull request created: #1070

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-medium bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants