fix: create ssh service with no labels obj #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hstastna
reviewed
Feb 9, 2023
| ) => { | ||
| const vmWithLabel = produce(vm, (draftVM) => { | ||
| if (!draftVM?.spec?.template?.metadata) { | ||
| draftVM.spec.template.metadata = {}; |
There was a problem hiding this comment.
Maybe you could use ensurePath here, the one from the other PR? :)
There was a problem hiding this comment.
right, let's wait for the other pr first and I'll fix this
upalatucci
force-pushed
the
fix-ssh-service-creation
branch
from
b935171
to
3edb9ff
Compare
hstastna
approved these changes
Feb 9, 2023
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hstastna, metalice, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Error during ssh service creation.
VMs without
spec.template.metadata.labelsthrow errors on k8sPatch.Switch to
k8sUpdatecreating first the label object and after adding it