Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-22306: mount window drivers on wizard and vm disk tab #1045

Merged

Conversation

upalatucci
Copy link
Member

📝 Description

Add checkbox to mount or unmount windows drivers

How to know if the VM has windows drivers mounted?
Control over all containerDisk volumes and check if the windows drivers image URL is used by one of them.

🎥 Demo

Wizard
https://user-images.githubusercontent.com/29160323/217866274-68310d5b-b1f3-4bfe-a27c-479d6f2070c7.mp4

VM details
https://user-images.githubusercontent.com/29160323/217866280-4b51e7c5-62a4-4ff9-81f6-039ff5620506.mp4

@openshift-ci-robot
Copy link
Collaborator

@upalatucci: This pull request references CNV-22306 which is a valid jira issue.

In response to this:

📝 Description

Add checkbox to mount or unmount windows drivers

How to know if the VM has windows drivers mounted?
Control over all containerDisk volumes and check if the windows drivers image URL is used by one of them.

🎥 Demo

Wizard
https://user-images.githubusercontent.com/29160323/217866274-68310d5b-b1f3-4bfe-a27c-479d6f2070c7.mp4

VM details
https://user-images.githubusercontent.com/29160323/217866280-4b51e7c5-62a4-4ff9-81f6-039ff5620506.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@upalatucci upalatucci force-pushed the mount-drivers-checkbox branch 2 times, most recently from 5c4c6da to 4f437da Compare February 10, 2023 12:11
@upalatucci
Copy link
Member Author

/retest

1 similar comment
@upalatucci
Copy link
Member Author

/retest

@upalatucci
Copy link
Member Author

/retest

@upalatucci
Copy link
Member Author

@metalice can you lgtm?

@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Feb 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Feb 13, 2023
@openshift-merge-robot openshift-merge-robot merged commit a06d544 into kubevirt-ui:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants