Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-18014: Update text in Add volume modal #1056

Conversation

hstastna
Copy link

@hstastna hstastna commented Feb 15, 2023

📝 Description

Update the strings in the Add volume to boot from modal, same ones in the Edit modal in the Bootable volumes list, according to the design changes. Add the subtitle to Add volume to boot from modal: "You can upload a new volume or use an existing PersistentVolumeClaim (PVC)".

Add missing helper texts to some of the modal's fields - to Volume name and PVC project.

Update also some of the strings in the same components (as in Add volume to boot from modal) but used in other places (e.g. PVC project and PVC name drop downs), for consistency reasons.

Update the subtitle for Create new VirtualMachine page, according to the design document to "Select an option to create a VirtualMachine from."

Make the checkbox Clone existing PVC checked and disabled (so the user cannot change it, at least for now), so the user has to clone the PVC by default (for 4.13, may change in the future versions).

Make the HelpIcon next to the checkbox Clone existing PVC smaller, to be displayed as expected.

This PR is related to features:
https://issues.redhat.com/browse/CNV-18014
https://issues.redhat.com/browse/CNV-15501

🎥 Demo

Before:
When uploading a new volume/image:
a1_before
When using an existing PVC:
a2_before
Edit modal for the volumes in the Bootable volumes list:
edit_before
Creating a VM from volume:
select_before

After:
When uploading a new volume/image:
a1_afterr
When using an existing PVC:
a2_afterr
Edit modal for the volumes in the Bootable volumes list:
edit_vol_after
Creating a VM from volume:
select_after

@openshift-ci-robot
Copy link
Collaborator

@hstastna: This pull request references CNV-18014 which is a valid jira issue.

In response to this:

📝 Description

Update the strings in the Add volume to boot from modal, same ones in the Edit modal in the Bootable volumes list, according to the design changes.
Also add missing helper texts to some of the modal's fields, make the HelpIcon smaller to be displayed as expected.

Update also some of the strings in the same components (as in Add volume to boot from modal) but used in other places (e.g. PVC project and PVC name drop downs), for consistency reasons.

This PR is related to features:
https://issues.redhat.com/browse/CNV-18014
https://issues.redhat.com/browse/CNV-15501

🎥 Demo

Before:
When uploading a new volume/image:
a1_before
When using an existing PVC:
a2_before

After:
When uploading a new volume/image:
a1_after
When using an existing PVC:
a2_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hstastna hstastna force-pushed the Update_strings_Add_volume_to_boot_from_modal branch 2 times, most recently from c736283 to 2773bda Compare February 15, 2023 21:08
@openshift-ci-robot
Copy link
Collaborator

@hstastna: This pull request references CNV-18014 which is a valid jira issue.

In response to this:

📝 Description

Update the strings in the Add volume to boot from modal, same ones in the Edit modal in the Bootable volumes list, according to the design changes.
Also add missing helper texts to some of the modal's fields, make the HelpIcon smaller to be displayed as expected.

Update also some of the strings in the same components (as in Add volume to boot from modal) but used in other places (e.g. PVC project and PVC name drop downs), for consistency reasons.

This PR is related to features:
https://issues.redhat.com/browse/CNV-18014
https://issues.redhat.com/browse/CNV-15501

🎥 Demo

Before:
When uploading a new volume/image:
a1_before
When using an existing PVC:
a2_before
Edit modal for the volumes in the Bootable volumes list:
edit_before

After:
When uploading a new volume/image:
a1_after
When using an existing PVC:
a2_after
Edit modal for the volumes in the Bootable volumes list:
edit_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hstastna
Copy link
Author

@metalice @pcbailey @upalatucci @vojtechszocs please review

@openshift-ci-robot
Copy link
Collaborator

@hstastna: This pull request references CNV-18014 which is a valid jira issue.

In response to this:

📝 Description

Update the strings in the Add volume to boot from modal, same ones in the Edit modal in the Bootable volumes list, according to the design changes.
Also add missing helper texts to some of the modal's fields, make the HelpIcon smaller to be displayed as expected.

Update also some of the strings in the same components (as in Add volume to boot from modal) but used in other places (e.g. PVC project and PVC name drop downs), for consistency reasons.

Update the subtitle for Create new VirtualMachine page, according to the design document to "Select an option to create a VirtualMachine from."

This PR is related to features:
https://issues.redhat.com/browse/CNV-18014
https://issues.redhat.com/browse/CNV-15501

🎥 Demo

Before:
When uploading a new volume/image:
a1_before
When using an existing PVC:
a2_before
Edit modal for the volumes in the Bootable volumes list:
edit_before
Creating a VM from volume:
select_before

After:
When uploading a new volume/image:
a1_after
When using an existing PVC:
a2_after
Edit modal for the volumes in the Bootable volumes list:
edit_after
Creating a VM from volume:
select_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hstastna
Copy link
Author

/retest

Update the strings in the Add volume to boot from modal,
same ones in the Edit modal in the Bootable volumes list,
according to the design changes.
Also add missing helper texts to some of the modal's fields,
make the HelpIcon smaller to be displayed as expected.

Update also some of the strings in the same components
(as in Add volume to boot from modal) but used in other places
(e.g. PVC project and PVC name drop downs), for consistency reasons.

This PR is related to features:
https://issues.redhat.com/browse/CNV-18014
https://issues.redhat.com/browse/CNV-15501
@hstastna hstastna force-pushed the Update_strings_Add_volume_to_boot_from_modal branch from 2773bda to f9c0bcc Compare February 16, 2023 15:01
@openshift-ci-robot
Copy link
Collaborator

@hstastna: This pull request references CNV-18014 which is a valid jira issue.

In response to this:

📝 Description

Update the strings in the Add volume to boot from modal, same ones in the Edit modal in the Bootable volumes list, according to the design changes. Add the subtitle to Add volume to boot from modal.

Add missing helper texts to some of the modal's fields (to Volume name), make the HelpIcon smaller to be displayed as expected.

Update also some of the strings in the same components (as in Add volume to boot from modal) but used in other places (e.g. PVC project and PVC name drop downs), for consistency reasons.

Update the subtitle for Create new VirtualMachine page, according to the design document to "Select an option to create a VirtualMachine from."

Make the checkbox Clone existing PVC checked and disabled (so the user cannot change it, at least for now), so the user has to clone the PVC by default (for 4.13, may change in the future versions).

This PR is related to features:
https://issues.redhat.com/browse/CNV-18014
https://issues.redhat.com/browse/CNV-15501

🎥 Demo

Before:
When uploading a new volume/image:
a1_before
When using an existing PVC:
a2_before
Edit modal for the volumes in the Bootable volumes list:
edit_before
Creating a VM from volume:
select_before

After:
When uploading a new volume/image:
a1_after
When using an existing PVC:
a2_after
Edit modal for the volumes in the Bootable volumes list:
edit_after
Creating a VM from volume:
select_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

@hstastna: This pull request references CNV-18014 which is a valid jira issue.

In response to this:

📝 Description

Update the strings in the Add volume to boot from modal, same ones in the Edit modal in the Bootable volumes list, according to the design changes. Add the subtitle to Add volume to boot from modal.

Add missing helper texts to some of the modal's fields (to Volume name and PVC project).

Update also some of the strings in the same components (as in Add volume to boot from modal) but used in other places (e.g. PVC project and PVC name drop downs), for consistency reasons.

Update the subtitle for Create new VirtualMachine page, according to the design document to "Select an option to create a VirtualMachine from."

Make the checkbox Clone existing PVC checked and disabled (so the user cannot change it, at least for now), so the user has to clone the PVC by default (for 4.13, may change in the future versions).

Make the HelpIcon next to the checkbox _Clone existing PVC_smaller, to be displayed as expected.

This PR is related to features:
https://issues.redhat.com/browse/CNV-18014
https://issues.redhat.com/browse/CNV-15501

🎥 Demo

Before:
When uploading a new volume/image:
a1_before
When using an existing PVC:
a2_before
Edit modal for the volumes in the Bootable volumes list:
edit_before
Creating a VM from volume:
select_before

After:
When uploading a new volume/image:
a1_after
When using an existing PVC:
a2_after
Edit modal for the volumes in the Bootable volumes list:
edit_after
Creating a VM from volume:
select_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

@hstastna: This pull request references CNV-18014 which is a valid jira issue.

In response to this:

📝 Description

Update the strings in the Add volume to boot from modal, same ones in the Edit modal in the Bootable volumes list, according to the design changes. Add the subtitle to Add volume to boot from modal.

Add missing helper texts to some of the modal's fields - to Volume name and PVC project.

Update also some of the strings in the same components (as in Add volume to boot from modal) but used in other places (e.g. PVC project and PVC name drop downs), for consistency reasons.

Update the subtitle for Create new VirtualMachine page, according to the design document to "Select an option to create a VirtualMachine from."

Make the checkbox Clone existing PVC checked and disabled (so the user cannot change it, at least for now), so the user has to clone the PVC by default (for 4.13, may change in the future versions).

Make the HelpIcon next to the checkbox _Clone existing PVC_smaller, to be displayed as expected.

This PR is related to features:
https://issues.redhat.com/browse/CNV-18014
https://issues.redhat.com/browse/CNV-15501

🎥 Demo

Before:
When uploading a new volume/image:
a1_before
When using an existing PVC:
a2_before
Edit modal for the volumes in the Bootable volumes list:
edit_before
Creating a VM from volume:
select_before

After:
When uploading a new volume/image:
a1_after
When using an existing PVC:
a2_after
Edit modal for the volumes in the Bootable volumes list:
edit_after
Creating a VM from volume:
select_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

@hstastna: This pull request references CNV-18014 which is a valid jira issue.

In response to this:

📝 Description

Update the strings in the Add volume to boot from modal, same ones in the Edit modal in the Bootable volumes list, according to the design changes. Add the subtitle to Add volume to boot from modal: "You can upload a new volume or use an existing PersistentVolumeClaim (PVC)".

Add missing helper texts to some of the modal's fields - to Volume name and PVC project.

Update also some of the strings in the same components (as in Add volume to boot from modal) but used in other places (e.g. PVC project and PVC name drop downs), for consistency reasons.

Update the subtitle for Create new VirtualMachine page, according to the design document to "Select an option to create a VirtualMachine from."

Make the checkbox Clone existing PVC checked and disabled (so the user cannot change it, at least for now), so the user has to clone the PVC by default (for 4.13, may change in the future versions).

Make the HelpIcon next to the checkbox _Clone existing PVC_smaller, to be displayed as expected.

This PR is related to features:
https://issues.redhat.com/browse/CNV-18014
https://issues.redhat.com/browse/CNV-15501

🎥 Demo

Before:
When uploading a new volume/image:
a1_before
When using an existing PVC:
a2_before
Edit modal for the volumes in the Bootable volumes list:
edit_before
Creating a VM from volume:
select_before

After:
When uploading a new volume/image:
a1_after
When using an existing PVC:
a2_after
Edit modal for the volumes in the Bootable volumes list:
edit_after
Creating a VM from volume:
select_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

@hstastna: This pull request references CNV-18014 which is a valid jira issue.

In response to this:

📝 Description

Update the strings in the Add volume to boot from modal, same ones in the Edit modal in the Bootable volumes list, according to the design changes. Add the subtitle to Add volume to boot from modal: "You can upload a new volume or use an existing PersistentVolumeClaim (PVC)".

Add missing helper texts to some of the modal's fields - to Volume name and PVC project.

Update also some of the strings in the same components (as in Add volume to boot from modal) but used in other places (e.g. PVC project and PVC name drop downs), for consistency reasons.

Update the subtitle for Create new VirtualMachine page, according to the design document to "Select an option to create a VirtualMachine from."

Make the checkbox Clone existing PVC checked and disabled (so the user cannot change it, at least for now), so the user has to clone the PVC by default (for 4.13, may change in the future versions).

Make the HelpIcon next to the checkbox Clone existing PVC smaller, to be displayed as expected.

This PR is related to features:
https://issues.redhat.com/browse/CNV-18014
https://issues.redhat.com/browse/CNV-15501

🎥 Demo

Before:
When uploading a new volume/image:
a1_before
When using an existing PVC:
a2_before
Edit modal for the volumes in the Bootable volumes list:
edit_before
Creating a VM from volume:
select_before

After:
When uploading a new volume/image:
a1_after
When using an existing PVC:
a2_after
Edit modal for the volumes in the Bootable volumes list:
edit_after
Creating a VM from volume:
select_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

@hstastna: This pull request references CNV-18014 which is a valid jira issue.

In response to this:

📝 Description

Update the strings in the Add volume to boot from modal, same ones in the Edit modal in the Bootable volumes list, according to the design changes. Add the subtitle to Add volume to boot from modal: "You can upload a new volume or use an existing PersistentVolumeClaim (PVC)".

Add missing helper texts to some of the modal's fields - to Volume name and PVC project.

Update also some of the strings in the same components (as in Add volume to boot from modal) but used in other places (e.g. PVC project and PVC name drop downs), for consistency reasons.

Update the subtitle for Create new VirtualMachine page, according to the design document to "Select an option to create a VirtualMachine from."

Make the checkbox Clone existing PVC checked and disabled (so the user cannot change it, at least for now), so the user has to clone the PVC by default (for 4.13, may change in the future versions).

Make the HelpIcon next to the checkbox Clone existing PVC smaller, to be displayed as expected.

This PR is related to features:
https://issues.redhat.com/browse/CNV-18014
https://issues.redhat.com/browse/CNV-15501

🎥 Demo

Before:
When uploading a new volume/image:
a1_before
When using an existing PVC:
a2_before
Edit modal for the volumes in the Bootable volumes list:
edit_before
Creating a VM from volume:
select_before

After:
When uploading a new volume/image:

When using an existing PVC:

Edit modal for the volumes in the Bootable volumes list:
edit_after
Creating a VM from volume:
select_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

@hstastna: This pull request references CNV-18014 which is a valid jira issue.

In response to this:

📝 Description

Update the strings in the Add volume to boot from modal, same ones in the Edit modal in the Bootable volumes list, according to the design changes. Add the subtitle to Add volume to boot from modal: "You can upload a new volume or use an existing PersistentVolumeClaim (PVC)".

Add missing helper texts to some of the modal's fields - to Volume name and PVC project.

Update also some of the strings in the same components (as in Add volume to boot from modal) but used in other places (e.g. PVC project and PVC name drop downs), for consistency reasons.

Update the subtitle for Create new VirtualMachine page, according to the design document to "Select an option to create a VirtualMachine from."

Make the checkbox Clone existing PVC checked and disabled (so the user cannot change it, at least for now), so the user has to clone the PVC by default (for 4.13, may change in the future versions).

Make the HelpIcon next to the checkbox Clone existing PVC smaller, to be displayed as expected.

This PR is related to features:
https://issues.redhat.com/browse/CNV-18014
https://issues.redhat.com/browse/CNV-15501

🎥 Demo

Before:
When uploading a new volume/image:
a1_before
When using an existing PVC:
a2_before
Edit modal for the volumes in the Bootable volumes list:
edit_before
Creating a VM from volume:
select_before

After:
When uploading a new volume/image:
a1_afterr
When using an existing PVC:
a2_afterr
Edit modal for the volumes in the Bootable volumes list:
edit_after
Creating a VM from volume:
select_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

@hstastna: This pull request references CNV-18014 which is a valid jira issue.

In response to this:

📝 Description

Update the strings in the Add volume to boot from modal, same ones in the Edit modal in the Bootable volumes list, according to the design changes. Add the subtitle to Add volume to boot from modal: "You can upload a new volume or use an existing PersistentVolumeClaim (PVC)".

Add missing helper texts to some of the modal's fields - to Volume name and PVC project.

Update also some of the strings in the same components (as in Add volume to boot from modal) but used in other places (e.g. PVC project and PVC name drop downs), for consistency reasons.

Update the subtitle for Create new VirtualMachine page, according to the design document to "Select an option to create a VirtualMachine from."

Make the checkbox Clone existing PVC checked and disabled (so the user cannot change it, at least for now), so the user has to clone the PVC by default (for 4.13, may change in the future versions).

Make the HelpIcon next to the checkbox Clone existing PVC smaller, to be displayed as expected.

This PR is related to features:
https://issues.redhat.com/browse/CNV-18014
https://issues.redhat.com/browse/CNV-15501

🎥 Demo

Before:
When uploading a new volume/image:
a1_before
When using an existing PVC:
a2_before
Edit modal for the volumes in the Bootable volumes list:
edit_before
Creating a VM from volume:
select_before

After:
When uploading a new volume/image:
a1_afterr
When using an existing PVC:
a2_afterr
Edit modal for the volumes in the Bootable volumes list:
edit_vol_after
Creating a VM from volume:
select_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pcbailey
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Feb 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Feb 17, 2023
@openshift-merge-robot openshift-merge-robot merged commit 64d5911 into kubevirt-ui:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants