-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-18014: Update text in Add volume modal #1056
CNV-18014: Update text in Add volume modal #1056
Conversation
@hstastna: This pull request references CNV-18014 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
c736283
to
2773bda
Compare
@hstastna: This pull request references CNV-18014 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@metalice @pcbailey @upalatucci @vojtechszocs please review |
@hstastna: This pull request references CNV-18014 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
Update the strings in the Add volume to boot from modal, same ones in the Edit modal in the Bootable volumes list, according to the design changes. Also add missing helper texts to some of the modal's fields, make the HelpIcon smaller to be displayed as expected. Update also some of the strings in the same components (as in Add volume to boot from modal) but used in other places (e.g. PVC project and PVC name drop downs), for consistency reasons. This PR is related to features: https://issues.redhat.com/browse/CNV-18014 https://issues.redhat.com/browse/CNV-15501
2773bda
to
f9c0bcc
Compare
@hstastna: This pull request references CNV-18014 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@hstastna: This pull request references CNV-18014 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@hstastna: This pull request references CNV-18014 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@hstastna: This pull request references CNV-18014 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@hstastna: This pull request references CNV-18014 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@hstastna: This pull request references CNV-18014 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@hstastna: This pull request references CNV-18014 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@hstastna: This pull request references CNV-18014 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hstastna, pcbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
Update the strings in the Add volume to boot from modal, same ones in the Edit modal in the Bootable volumes list, according to the design changes. Add the subtitle to Add volume to boot from modal: "You can upload a new volume or use an existing PersistentVolumeClaim (PVC)".
Add missing helper texts to some of the modal's fields - to Volume name and PVC project.
Update also some of the strings in the same components (as in Add volume to boot from modal) but used in other places (e.g. PVC project and PVC name drop downs), for consistency reasons.
Update the subtitle for Create new VirtualMachine page, according to the design document to "Select an option to create a VirtualMachine from."
Make the checkbox Clone existing PVC checked and disabled (so the user cannot change it, at least for now), so the user has to clone the PVC by default (for 4.13, may change in the future versions).
Make the
HelpIcon
next to the checkbox Clone existing PVC smaller, to be displayed as expected.This PR is related to features:
https://issues.redhat.com/browse/CNV-18014
https://issues.redhat.com/browse/CNV-15501
🎥 Demo
Before:
When uploading a new volume/image:
When using an existing PVC:
Edit modal for the volumes in the Bootable volumes list:
Creating a VM from volume:
After:
When uploading a new volume/image:
When using an existing PVC:
Edit modal for the volumes in the Bootable volumes list:
Creating a VM from volume: