Bug 2177977: The volume in instanceTypes page should be selected automatically just after it's been added

[avivtur]

📝 Description

This PR fixes:

• Selecting the volume from the Add volume modal + including a label for cloning in progress
• Getting correct size for volume that is cloned from another PVC instead of 0 B (saw this regression a few days ago on another cluster)
• Disabling Add volume button if user is not allowed to create a DataSource object within the os images name (either kubevirt-os-images for US or openshift-virtualization-os-images for DS)

🎥 Demo

Before:

select-created-volume-with-clone-in-progress-label-b4.mp4

After:

select-created-volume-with-clone-in-progress-label.mp4

[openshift-ci]

@avivtur: This pull request references Bugzilla bug 2177977, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.14.0) matches configured target release for branch (4.14.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2177977: The volume in instanceTypes page should be selected automatically just after it's been added

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[metalice]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [avivtur,metalice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@avivtur: All pull requests linked via external trackers have merged:

• kubevirt-ui/kubevirt-plugin#1192

Bugzilla bug 2177977 has been moved to the MODIFIED state.

In response to this:

Bug 2177977: The volume in instanceTypes page should be selected automatically just after it's been added

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gouyang]

/cherry-pick release-4.13

[openshift-cherrypick-robot]

@gouyang: #1192 failed to apply on top of branch "release-4.13":

Applying: Bug 2177977: The volume in instanceTypes page should be selected automatically just after it's been added
Using index info to reconstruct a base tree...
M	src/views/catalog/CreateFromInstanceTypes/CreateFromInstanceType.tsx
M	src/views/catalog/CreateFromInstanceTypes/components/BootableVolumeList/components/BootableVolumeRow/BootableVolumeRow.tsx
Falling back to patching base and 3-way merge...
Auto-merging src/views/catalog/CreateFromInstanceTypes/components/BootableVolumeList/components/BootableVolumeRow/BootableVolumeRow.tsx
CONFLICT (content): Merge conflict in src/views/catalog/CreateFromInstanceTypes/components/BootableVolumeList/components/BootableVolumeRow/BootableVolumeRow.tsx
Auto-merging src/views/catalog/CreateFromInstanceTypes/CreateFromInstanceType.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bug 2177977: The volume in instanceTypes page should be selected automatically just after it's been added
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.