Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main README.md #1214

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Mar 29, 2023

📝 Description

Updating the recommended local development options

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Mar 29, 2023
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated

1. Run `yarn && yarn dev`

NOTE: `./start-console-auth-mode.sh` is when login page is needed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start-console start ignore authentication and auth-mode isn't ignoring

maybe?
NOTE: ./start-console-auth-mode.sh is when authentication is needed, start-console.sh, ignores authentication.

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Mar 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 364bc7a into kubevirt-ui:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants