Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2182233: Enforcing ssh secret name to be 51 chars or less #1219

Conversation

metalice
Copy link
Member

📝 Description

The secret volume has a maximum of 63 chars. The BE adds more chars to the volume name extending our secret name, and this fix limits the chars to 51 to stay safe with the 63 volume limit.

🎥 Demo

Please add a video or an image of the behavior/changes

Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2023

@metalice: This pull request references Bugzilla bug 2182233, which is invalid:

  • expected the bug to target the "4.14.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2182233: Enforcing ssh secret name to be 51 chars or less

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Mar 30, 2023
@metalice
Copy link
Member Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2023

@metalice: This pull request references Bugzilla bug 2182233, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.14.0) matches configured target release for branch (4.14.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gouyang March 30, 2023 10:41
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Mar 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ceacb5d into kubevirt-ui:main Mar 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2023

@metalice: All pull requests linked via external trackers have merged:

Bugzilla bug 2182233 has been moved to the MODIFIED state.

In response to this:

Bug 2182233: Enforcing ssh secret name to be 51 chars or less

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-medium bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants