Bug 2183491: Truncate PVC name in Add volume modal #1238
Conversation
Truncate the PVC name options for the PVC name drop down in Add volume modal (when selecting "Use existing volume" radio button) in case when the name is too long according to the width of the modal. Display the whole name in the popover displayed on mouseover. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2183491
|
@hstastna: This pull request references Bugzilla bug 2183491, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@hstastna: This pull request references Bugzilla bug 2183491, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hstastna, pcbailey, vojtechszocs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@hstastna: All pull requests linked via external trackers have merged: Bugzilla bug 2183491 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
📝 Description
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2183491
Truncate the PVC name options for the PVC name drop down in Add volume modal (when selecting Use existing volume radio button) in case when the name is too long according to the width of the modal. Display the whole name in the popover displayed on mouseover.
Note that the decision to make this change to fix the problem of not displaying the modal nicely when PVC name is too long, was made by the UX, of course.
Patternfly
TruncateReact component, used in this PR:https://www.patternfly.org/2022.11/components/truncate
🎥 Screenshots
Before:
After:
