Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2176797: Make "YAML" button consistent in Disks tabs #1239

Conversation

hstastna
Copy link

@hstastna hstastna commented Apr 6, 2023

📝 Description

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2176797

Move the "Add ..." buttons below the title of the page, add missing titles, so the YAML switcher can be placed next to the title of the page, to make the page more consistent with other pages containing YAML switcher. Make these changes in the following pages:

  • VM Disks tab
  • Catalog wizard Disks tab
  • VM Template Disks tab

Refactor DiskListTitle component, update the related css files for better look, make it universal, move it to utils and use it in the pages mentioned above.

Note:
More than just this PR will be created to completely fix the BZ 2176797.

🎥 Screenshots

Before:
VM Disks tab:
vm_disk_before
Catalog wizard Disks tab:
wizard_disk_before
VM Template Disks tab:
templates_disk_before

After:
VM Disks tab:
vm_disk_after
Catalog wizard Disks tab:
wizard_disk_after
VM Template Disks tab:
templates_disk_after

Move the Add buttons below the title of the page, add missing titles,
so the YAML switcher can be placed next to the title of the page,
to make the page more consistent with other pages containing YAML
swithcer. Make these changes in the following pages:
- VM Disks tab
- Catalog wizard Disks tab
- VM Template Disks tab

Refactor DiskListTitle component, update the related css files for
better look, make it universal, move it to utils and use it in the
pages mentioned above.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2176797
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2023

@hstastna: This pull request references Bugzilla bug 2176797, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.14.0) matches configured target release for branch (4.14.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2176797: Make "YAML" button consistent in Disks tabs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Apr 6, 2023
@openshift-ci openshift-ci bot requested a review from gouyang April 6, 2023 13:49
@hstastna
Copy link
Author

hstastna commented Apr 6, 2023

@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Apr 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hstastna,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5db3558 into kubevirt-ui:main Apr 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2023

@hstastna: All pull requests linked via external trackers have merged:

Bugzilla bug 2176797 has been moved to the MODIFIED state.

In response to this:

Bug 2176797: Make "YAML" button consistent in Disks tabs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-medium bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants