Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cypress tests #1264

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Apr 19, 2023

📝 Description

Fixing cypress test:

  • Aligning text to fit current text in the app.

  • filter.spec.ts:

  1. the visit function was flaky changed to the visitCatalog function.
  2. changing rhel 6 to 9 and using metadata name instead of name as it didn't match anymore.
  3. switch to check for fedora template instead of checking just count of templates (crashes locally when having more than one fedora template).
  • check-tabs.spec.ts:
  1. creating vm/template from yaml gets a resource name example for both cases.
  2. common template alert text didn't matched - getting by id instead of text.

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Apr 19, 2023
@gouyang
Copy link
Member

gouyang commented Apr 19, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Apr 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, gouyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4291cd2 into kubevirt-ui:main Apr 19, 2023
avivtur pushed a commit to avivtur/kubevirt-plugin that referenced this pull request Apr 19, 2023
avivtur pushed a commit to avivtur/kubevirt-plugin that referenced this pull request Apr 19, 2023
avivtur pushed a commit to avivtur/kubevirt-plugin that referenced this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants