Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2172945: Hamburger button in "Review and create VirtualMachine" Disks sometime disappear #1267

Merged

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Apr 19, 2023

📝 Description

Making actions consistent with every page width

🎥 Demo

Before:

kebab-disappear.mp4

After:

kebab-disappear-fxd.mp4

…Disks sometime disappear

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Apr 19, 2023
@avivtur avivtur changed the title Bug 2172945 - Hamburger button in "Review and create VirtualMachine" Disks sometime disappear Bug 2172945: Hamburger button in "Review and create VirtualMachine" Disks sometime disappear Apr 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 19, 2023

@avivtur: This pull request references Bugzilla bug 2172945, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.14.0) matches configured target release for branch (4.14.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2172945: Hamburger button in "Review and create VirtualMachine" Disks sometime disappear

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gouyang April 19, 2023 12:42
@upalatucci
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Apr 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a10dac9 into kubevirt-ui:main Apr 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 20, 2023

@avivtur: All pull requests linked via external trackers have merged:

Bugzilla bug 2172945 has been moved to the MODIFIED state.

In response to this:

Bug 2172945: Hamburger button in "Review and create VirtualMachine" Disks sometime disappear

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-unspecified bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants