Bug 2188886: Pending loading on detach modal #1273
Conversation
|
@upalatucci: This pull request references Bugzilla bug 2188886, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
upalatucci
force-pushed
the
detach-modal-error
branch
from
f4d42c5
to
b8c36d8
Compare
upalatucci
force-pushed
the
detach-modal-error
branch
from
b8c36d8
to
d73c3e3
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@upalatucci: All pull requests linked via external trackers have merged: Bugzilla bug 2188886 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
📝 Description
Cause
We transform volume in
persistentVolumeClaimwithconvertDataVolumeToPVCeven when the volume is not a DV.Solution
Do not transform the volume if it's not a datavolume.
To prevent further issues, let's show the fetch error to the user when something goes wrong.
If we fail to load the resource, we'll not be able to delete it or detach it
I've added a prop to the TabModal as in this component the error alert is already showed for API errors and can be useful for other modals that use tabmodal