Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-28334: Adding ability to user settings column managment - part 2 #1286

Conversation

metalice
Copy link
Member

@metalice metalice commented May 2, 2023

📝 Description

Part 2:
Connection all table that used useActiveColumn to our new KubevirtColumns hook, that will keep the user settings about columns management persistent.

🎥 Demo

Please add a video or an image of the behavior/changes

Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

@metalice: This pull request references CNV-28334 which is a valid jira issue.

In response to this:

📝 Description

Part 2:
Connection all table that used useActiveColumn to our new KubevirtColumns hook, that will keep the user settings about columns management persistent.

🎥 Demo

Please add a video or an image of the behavior/changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from hstastna and tnisan May 2, 2023 12:02
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label May 2, 2023
@upalatucci
Copy link
Member

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label May 2, 2023
@openshift-merge-robot openshift-merge-robot merged commit b416283 into kubevirt-ui:main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants