-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-32823: Update the example of VM and template YAML #1531
CNV-32823: Update the example of VM and template YAML #1531
Conversation
Update the "example" YAML of both VM and template used in the UI. Replace "vm.spec.template.spec.domain.resources.requests.memory" with "vm.spec.template.spec.domain.memory.guest" in the VM object, so the memory value gets saved correctly, according to the recent backend change introduced in kubevirt/common-templates#543. Fixes https://issues.redhat.com/browse/CNV-32823
@hstastna: This pull request references CNV-32823 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@hstastna: This pull request references CNV-32823 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@hstastna: This pull request references CNV-32823 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hstastna, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-4.14 |
@gouyang: new pull request created: #1549 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
📝 Description
Fixes:
https://issues.redhat.com/browse/CNV-32823
Update the "example" YAML of both VM and template used in the UI. Replace
vm.spec.template.spec.domain.resources.requests.memory
withvm.spec.template.spec.domain.memory.guest
in the VM object, so the memory value gets saved correctly, according to the recent backend change introduced inkubevirt/common-templates#543.
Note that the bug this PR is fixing, fortunately didn't prevent VM to be created successfully and ran.
Also note that VM creation from "example" template works as expected, too, with this PR, so its YAML is created and updated correctly.
🎥 Demo
Before:
"example" template creation - template created successfully, but incorrect YAML represetation regarding memory:
template_before.mp4
VM creation "With YAML" - VM created successfully, but incorrect YAML represetation regarding memory:
vm_before.mp4
After:
"example" template creation - correct YAML:
template_after.mp4
VM creation "With YAML" - correct YAML:
vm_afterrr.mp4