Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-32665: Fix hot plug NIC not added to VMI after live migration #1535

Merged

Conversation

pcbailey
Copy link
Member

@pcbailey pcbailey commented Sep 13, 2023

📝 Description

This fixes a bug wherein a secondary hot-plugged NIC is added to a VM, but it is not added to the VMI after live migration.

jira issue: https://issues.redhat.com/browse/CNV-32665

🎥 Screenshots

Hot-plug NIC added - Before migration

2023-09-16_15-41

After migration

2023-09-16_15-42

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 13, 2023

@pcbailey: This pull request references CNV-32665 which is a valid jira issue.

In response to this:

📝 Description

This fixes a bug wherein a secondary hot-plugged NIC is added to a VM, but it is not added to the VMI after live migration.

jira issue: https://issues.redhat.com/browse/CNV-32665

🎥 Demo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Sep 13, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 16, 2023

@pcbailey: This pull request references CNV-32665 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

📝 Description

This fixes a bug wherein a secondary hot-plugged NIC is added to a VM, but it is not added to the VMI after live migration.

jira issue: https://issues.redhat.com/browse/CNV-32665

🎥 Screenshots

Before

2023-09-16_15-41

After

2023-09-16_15-42

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 16, 2023

@pcbailey: This pull request references CNV-32665 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

📝 Description

This fixes a bug wherein a secondary hot-plugged NIC is added to a VM, but it is not added to the VMI after live migration.

jira issue: https://issues.redhat.com/browse/CNV-32665

🎥 Screenshots

Hot-plug NIC added - Before migration

2023-09-16_15-41

After migration

2023-09-16_15-42

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pcbailey pcbailey changed the title WIP: CNV-32665: Fix hot plug NIC not added to VMI after live migration CNV-32665: Fix hot plug NIC not added to VMI after live migration Sep 16, 2023
@@ -12,10 +12,10 @@ const typeHandler = {
},
};

const types = {
export const NetworkTypes = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to export it. u can simply use import interfaceTypes, it is a proxy, you will get a value from type if exisit if not u will get Bridge as the default value.

@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Sep 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metalice
Copy link
Member

/retest

1 similar comment
@pcbailey
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit ee944d9 into kubevirt-ui:main Sep 18, 2023
8 checks passed
@gouyang
Copy link
Member

gouyang commented Sep 19, 2023

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link
Collaborator

@gouyang: #1535 failed to apply on top of branch "release-4.14":

Applying: Fix hot plug NIC not added to VMI after live migration
Using index info to reconstruct a base tree...
M	src/views/catalog/templatescatalog/components/TemplatesCatalogDrawer/TemplateCatalogDrawer.scss
Falling back to patching base and 3-way merge...
Auto-merging src/views/catalog/templatescatalog/components/TemplatesCatalogDrawer/TemplateCatalogDrawer.scss
CONFLICT (content): Merge conflict in src/views/catalog/templatescatalog/components/TemplatesCatalogDrawer/TemplateCatalogDrawer.scss
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix hot plug NIC not added to VMI after live migration
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pcbailey pushed a commit to pcbailey/kubevirt-plugin that referenced this pull request Sep 20, 2023
CNV-32665: Fix hot plug NIC not added to VMI after live migration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants