-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-32665: Fix hot plug NIC not added to VMI after live migration #1535
CNV-32665: Fix hot plug NIC not added to VMI after live migration #1535
Conversation
@pcbailey: This pull request references CNV-32665 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
506359b
to
c9f55d4
Compare
@pcbailey: This pull request references CNV-32665 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pcbailey: This pull request references CNV-32665 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -12,10 +12,10 @@ const typeHandler = { | |||
}, | |||
}; | |||
|
|||
const types = { | |||
export const NetworkTypes = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to export it. u can simply use import interfaceTypes, it is a proxy, you will get a value from type if exisit if not u will get Bridge as the default value.
c9f55d4
to
a61a7b0
Compare
a61a7b0
to
9838752
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, pcbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
/cherry-pick release-4.14 |
@gouyang: #1535 failed to apply on top of branch "release-4.14":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
CNV-32665: Fix hot plug NIC not added to VMI after live migration
📝 Description
This fixes a bug wherein a secondary hot-plugged NIC is added to a VM, but it is not added to the VMI after live migration.
jira issue: https://issues.redhat.com/browse/CNV-32665
🎥 Screenshots
Hot-plug NIC added - Before migration
After migration