Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-32874: Customize VM is prompting 'No boot source available' dialog #1536

Merged

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Sep 13, 2023

📝 Description

When adding size input for default source #1529
We accidentally override the boot source's source

🎥 Demo

Before:

no-source.mp4

After:

no-source-after.mp4

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 13, 2023

@avivtur: This pull request references CNV-32874 which is a valid jira issue.

In response to this:

📝 Description

When adding size input for default source #1529
We accidentally override the boot source's source

🎥 Demo

Before:

no-source.mp4

After:

no-source-after.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Sep 13, 2023
@avivtur
Copy link
Member Author

avivtur commented Sep 13, 2023

/retest

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Sep 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metalice
Copy link
Member

/retest

2 similar comments
@metalice
Copy link
Member

/retest

@metalice
Copy link
Member

/retest

@metalice metalice closed this Sep 17, 2023
@metalice metalice reopened this Sep 17, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 17, 2023

@avivtur: This pull request references CNV-32874 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

📝 Description

When adding size input for default source #1529
We accidentally override the boot source's source

🎥 Demo

Before:

no-source.mp4

After:

no-source-after.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 3d7f545 into kubevirt-ui:main Sep 17, 2023
8 checks passed
@gouyang
Copy link
Member

gouyang commented Sep 19, 2023

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link
Collaborator

@gouyang: new pull request created: #1550

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants