Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-32958: Rename "From volume" to "From InstanceType" #1543

Conversation

hstastna
Copy link

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-32958

When creating a VM in VirtualMachines list page, change creating VM drop down item from "From volume" to "From InstanceType" to align more with "InstanceTypes" tab, to which clicking on that menu item leads.

🎥 Screenshots

Before:
is_before

After:
is_after

When creating a VM in VirtualMachines list page, change creating VM drop
down item from "From volume" to "From InstanceType" to align more with
"InstanceTypes" tab, to which clicking on that menu item leads.

Fixes https://issues.redhat.com/browse/CNV-32958
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 14, 2023

@hstastna: This pull request references CNV-32958 which is a valid jira issue.

In response to this:

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-32958

When creating a VM in VirtualMachines list page, change creating VM drop down item from "From volume" to "From InstanceType" to align more with "InstanceTypes" tab, to which clicking on that menu item leads.

🎥 Screenshots

Before:
is_before

After:
is_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Sep 14, 2023
@hstastna
Copy link
Author

@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review

@pcbailey
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Sep 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d09ef3e into kubevirt-ui:main Sep 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants