CNV-33133: Make buttons in VMs and MigrationPolicies pages not blink

[hstastna]

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-33133

Make empty state related buttons for VirtualMachines list and MigrationPolicies list pages not blink, when entering those pages for the first time.

Note that the problem this PR is fixing, is not so easy to reproduce and not always reproducible, you must try couple of times to see the issue there.

🎥 Demo

Before:
VirtualMachines list page (see how the buttons blink once or twice when entering the page):

flicker_before.mp4

MigrationPolicies list page (see how the buttons blink once or twice when entering the page):

mps_before.mp4

After:
VirtualMachines list page (no any blinking anymore):

flicker_after.mp4

MigrationPolicies list page (no any blinking anymore):

mps_after.mp4

Comparing the behavior of the two implementations of empty state screen (within the one screen):
VirtualMachines list page:

vms_emptystate_comparing.mp4

MigrationPolicies list page:

mps_emptystate_comparing.mp4

[openshift-ci-robot]

@hstastna: This pull request references CNV-33133 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-33133

Make empty state related buttons for VirtualMachines list and MigrationPolicies list pages not blink, when entering those pages for the first time.

🎥 Demo

Before:
VirtualMachines list page:

flicker_before.mp4

MigrationPolicies list page:

mps_before.mp4

After:
VirtualMachines list page:

flicker_after.mp4

MigrationPolicies list page:

mps_after.mp4

Comparing the behavior of the two implementations of empty state screen (within the one screen):
VirtualMachines list page:

vms_emptystate_comparing.mp4

MigrationPolicies list page:

mps_emptystate_comparing.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@hstastna: This pull request references CNV-33133 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-33133

Make empty state related buttons for VirtualMachines list and MigrationPolicies list pages not blink, when entering those pages for the first time.

🎥 Demo

Before:
VirtualMachines list page (see how the buttons blink once or twice when entering the page):

flicker_before.mp4

MigrationPolicies list page (see how the buttons blink once or twice when entering the page):

mps_before.mp4

After:
VirtualMachines list page:

flicker_after.mp4

MigrationPolicies list page:

mps_after.mp4

Comparing the behavior of the two implementations of empty state screen (within the one screen):
VirtualMachines list page:

vms_emptystate_comparing.mp4

MigrationPolicies list page:

mps_emptystate_comparing.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hstastna]

@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review

[openshift-ci-robot]

@hstastna: This pull request references CNV-33133 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-33133

Make empty state related buttons for VirtualMachines list and MigrationPolicies list pages not blink, when entering those pages for the first time.

Note that the problem this PR is fixing, is not so easy to reproduce and not always reproducible, you must try couple of times to see the issue there.

🎥 Demo

Before:
VirtualMachines list page (see how the buttons blink once or twice when entering the page):

flicker_before.mp4

MigrationPolicies list page (see how the buttons blink once or twice when entering the page):

mps_before.mp4

After:
VirtualMachines list page (no any blinking anymore):

flicker_after.mp4

MigrationPolicies list page (no any blinking anymore):

mps_after.mp4

Comparing the behavior of the two implementations of empty state screen (within the one screen):
VirtualMachines list page:

vms_emptystate_comparing.mp4

MigrationPolicies list page:

mps_emptystate_comparing.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pcbailey]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hstastna,pcbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[metalice]

Hey
how it works with filtering with no results? No issues in this case of simple empty page?

[hstastna]

Hey how it works with filtering with no results? No issues in this case of simple empty page?

Filtering with no results works as it worked before this change. I was not changing this behavior.

[metalice]

Hey how it works with filtering with no results? No issues in this case of simple empty page?

Filtering with no results works as it worked before this change. I was not changing this behavior.

cool, so I think the prop NoDataEmptyMsg and EmptyMsg can be removed instead of sending a fragment, I belive they aren't mandatory.

[hstastna]

Hey how it works with filtering with no results? No issues in this case of simple empty page?

Filtering with no results works as it worked before this change. I was not changing this behavior.

cool, so I think the prop NoDataEmptyMsg and EmptyMsg can be removed instead of sending a fragment, I belive they aren't mandatory.

No, if those are totally missing, it renders extra "Not found". Everything in this PR, every change has its good purpose.

[gouyang]

/cherry-pick release-4.14

[openshift-cherrypick-robot]

@gouyang: new pull request created: #1597

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.