CNV-33531: Fix broken Diagnostics link in VM Overview Details card

[hstastna]

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-33531

Make View diagnostic broken link, displayed in VM Overview Details card Status popover, lead to Diagnostics tab successfully, in case of some VM status error. Make the link work by using createUrl util to generate the url for the page correctly.

Note that when finding and then investigating this bug, I've found that all other links present in the VM Overview tab were created by use of createUrl. It seems it was just forgotten to use it also for that broken link hidden in the popover of one field in that page.

Also note that you must click on Overview tab to be able to always reproduce the bug. When accessing Overview tab from VM list page and not clicking on the tab name explicitly, you won't be able to reproduce the bug, because the url string will be missing "/" at its end.

🎥 Demo

Before:

diag_before.mp4

After:

diag_after.mp4

[openshift-ci-robot]

@hstastna: This pull request references CNV-33531 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-33531

Make View diagnostic broken link, displayed in VM Overview Details card Status popover, lead to Diagnostics tab successfully, in case of some VM status error. Make the link work by using createUrl util to generate the url for the page correctly.

Note that when investigating this bug, I've found that all other links present in the VM Overview tab were created by use of createUrl. It seems it was just forgotten to use it also for that broken link hidden in the popover of one field in that page.

Also note that you must click on Overview tab to be able to always reproduce the bug. When accessing Overview tab from VM list page and not clicking on the tab name explicitly, you won't be able to reproduce the bug, because the url string will be missing "/" at its end.

🎥 Demo

Before:

diag_before.mp4

After:

diag_after.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hstastna]

@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review

[openshift-ci-robot]

@hstastna: This pull request references CNV-33531 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-33531

Make View diagnostic broken link, displayed in VM Overview Details card Status popover, lead to Diagnostics tab successfully, in case of some VM status error. Make the link work by using createUrl util to generate the url for the page correctly.

Note that when finding and then investigating this bug, I've found that all other links present in the VM Overview tab were created by use of createUrl. It seems it was just forgotten to use it also for that broken link hidden in the popover of one field in that page.

Also note that you must click on Overview tab to be able to always reproduce the bug. When accessing Overview tab from VM list page and not clicking on the tab name explicitly, you won't be able to reproduce the bug, because the url string will be missing "/" at its end.

🎥 Demo

Before:

diag_before.mp4

After:

diag_after.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pcbailey]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hstastna,pcbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment