Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNV-32097: add column management to the custom list filter #1578

Merged
merged 1 commit into from
Oct 12, 2023
Merged

CNV-32097: add column management to the custom list filter #1578

merged 1 commit into from
Oct 12, 2023

Conversation

upalatucci
Copy link
Member

📝 Description

Add Column Management modal to the custom ListPageFilter component

🎥 Demo

video-2023-10-04_17.44.34.mp4

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 4, 2023 •
edited by openshift-ci bot
Loading

@upalatucci: This pull request references CNV-32097 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set.

In response to this:

📝 Description

Add Column Management modal to the custom ListPageFilter component

🎥 Demo

video-2023-10-04_17.44.34.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from avivtur and tnisan October 4, 2023 15:48
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Oct 4, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 4, 2023 •
edited by openshift-ci bot
Loading

@upalatucci: This pull request references CNV-32097 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set.

In response to this:

📝 Description

Add Column Management modal to the custom ListPageFilter component

🎥 Demo

video-2023-10-04_17.44.34.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

metalice
metalice reviewed Oct 4, 2023
View reviewed changes
start-console.sh Outdated Show resolved Hide resolved
@upalatucci upalatucci force-pushed the column-management branch 3 times, most recently from bdc3336 to 22d7426 Compare October 5, 2023 09:16
avivtur
avivtur reviewed Oct 8, 2023
View reviewed changes
Copy link
Member

@avivtur avivtur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ugo excellent work!
I left a few comments, And I wonder about something:
The component we get from SDK now shows the namespace checkbox when we are scoped under any namespace, and it is not really functional, can you disable this checkbox when the current namespace exists (=not all namespaces)?

src/utils/components/ColumnManagementModal/ColumnManagementModal.tsx Outdated Show resolved Hide resolved
src/utils/components/ColumnManagementModal/ColumnManagementModal.tsx Outdated Show resolved Hide resolved
src/utils/components/ColumnManagementModal/ColumnManagementModal.tsx Outdated Show resolved Hide resolved
src/utils/components/ColumnManagementModal/ColumnManagementModal.tsx Show resolved Hide resolved
src/utils/components/ColumnManagementModal/ColumnManagementModal.tsx Outdated Show resolved Hide resolved
src/utils/components/ColumnManagementModal/ColumnManagementModal.tsx Outdated Show resolved Hide resolved
src/utils/components/ColumnManagementModal/ColumnManagementModal.tsx Outdated Show resolved Hide resolved
src/utils/components/ColumnManagementModal/ColumnManagementModal.tsx Outdated Show resolved Hide resolved
src/utils/components/ColumnManagementModal/DataListRow.tsx Outdated Show resolved Hide resolved
src/utils/components/ListPageFilter/ListPageFilter.tsx Outdated Show resolved Hide resolved
@avivtur
Copy link
Member

avivtur commented Oct 9, 2023

/lgtm
Perfect! Thanks @upalatucci 💯

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Oct 9, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 9, 2023 •
edited by openshift-ci bot
Loading

@upalatucci: This pull request references CNV-32097 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set.

In response to this:

📝 Description

Add Column Management modal to the custom ListPageFilter component

🎥 Demo

video-2023-10-04_17.44.34.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@upalatucci
Copy link
Member Author

/retest

1 similar comment
@upalatucci
Copy link
Member Author

/retest

@avivtur
Copy link
Member

avivtur commented Oct 10, 2023

/hold
@upalatucci please check why tests are failing

@openshift-ci openshift-ci bot removed the lgtm Passed code review, ready for merge label Oct 11, 2023
@upalatucci
Copy link
Member Author

/retest

@upalatucci
Copy link
Member Author

/retest ci/prow/kubevirt-e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2023

@upalatucci: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test images
  • /test kubevirt-e2e-aws

Use /test all to run all jobs.

In response to this:

/retest ci/prow/kubevirt-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@upalatucci
Copy link
Member Author

/test kubevirt-e2e-aws

@pcbailey
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Oct 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, pcbailey, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [avivtur,pcbailey,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@upalatucci
Copy link
Member Author

/unhold

@openshift-ci openshift-ci bot merged commit 9463792 into kubevirt-ui:main Oct 12, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalice metalice metalice left review comments

@avivtur avivtur avivtur left review comments

@tnisan tnisan Awaiting requested review from tnisan

Assignees

@pcbailey pcbailey

@avivtur avivtur

Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@upalatucci @openshift-ci-robot @avivtur @pcbailey @metalice