Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNV-32097: Add ip search capabilities #1585

Merged
merged 1 commit into from
Oct 18, 2023
Merged

CNV-32097: Add ip search capabilities #1585

merged 1 commit into from
Oct 18, 2023

Conversation

upalatucci
Copy link
Member

📝 Description

Search by IP.

Works also with CIDR on IPv4

🎥 Demo

Screenshot from 2023-10-13 10-52-48
Screenshot from 2023-10-13 10-52-39
Screenshot from 2023-10-13 10-52-55

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 13, 2023 •
edited by openshift-ci bot
Loading

@upalatucci: This pull request references CNV-32097 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set.

In response to this:

📝 Description

Search by IP.

Works also with CIDR on IPv4

🎥 Demo

Screenshot from 2023-10-13 10-52-48
Screenshot from 2023-10-13 10-52-39
Screenshot from 2023-10-13 10-52-55

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from avivtur and tnisan October 13, 2023 08:53
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Oct 13, 2023
@upalatucci
Copy link
Member Author

/retest

1 similar comment
@upalatucci
Copy link
Member Author

/retest

@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Oct 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 0767d1d into kubevirt-ui:main Oct 18, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalice metalice metalice left review comments

@avivtur avivtur Awaiting requested review from avivtur

@tnisan tnisan Awaiting requested review from tnisan

Assignees

@metalice metalice

Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@upalatucci @openshift-ci-robot @metalice