Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-30166: Move hot-plug bridged NICs feature to GA #1600

Merged

Conversation

pcbailey
Copy link
Member

@pcbailey pcbailey commented Nov 8, 2023

📝 Description

This PR:

  • Moves the hot-plug bridged NICs feature to GA
  • Fixes the link for the auto-compute CPU limits feature in the preview features section

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 8, 2023

@pcbailey: This pull request references CNV-30166 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.15." or "openshift-4.15.", but it targets "CNV v4.14.0" instead.

In response to this:

📝 Description

This PR moves the bridged hot-plug NICs feature to GA.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 21, 2023

@pcbailey: This pull request references CNV-30166 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.15." or "openshift-4.15.", but it targets "CNV v4.14.0" instead.

In response to this:

📝 Description

This PR:

  • Moves the hot-plug bridged NICs feature to GA
  • Fixes the link for the auto-compute CPU limits feature in the preview features section

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pcbailey pcbailey changed the title WIP: CNV-30166: Move bridged hot-plug NICs feature to GA CNV-30166: Move hot-plug bridged NICs feature to GA Nov 21, 2023
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Nov 21, 2023
Copy link
Contributor

openshift-ci bot commented Nov 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pcbailey,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e3d4cef into kubevirt-ui:main Nov 21, 2023
9 checks passed
);
};

export default EnablePreviewFeaturesSection;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this file is added? its unused

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants