Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNV-35849: Making instancetype default over template #1620

Merged
merged 1 commit into from
Nov 30, 2023
Merged

CNV-35849: Making instancetype default over template #1620

merged 1 commit into from
Nov 30, 2023

Conversation

metalice
Copy link
Member

📝 Description

Making instance type favorite over template.
1.changing routes to make it default
2. change the order of create button in VM list so instance type will be first.
3. change tabs in catalog so instance type will be first

🎥 Demo

Please add a video or an image of the behavior/changes

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 29, 2023 •
edited by openshift-ci bot
Loading

@metalice: This pull request references CNV-35849 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set.

In response to this:

📝 Description

Making instance type favorite over template.
1.changing routes to make it default
2. change the order of create button in VM list so instance type will be first.
3. change tabs in catalog so instance type will be first

🎥 Demo

Please add a video or an image of the behavior/changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Nov 29, 2023
@hstastna
Copy link

/retest

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Nov 29, 2023
@upalatucci
Copy link
Member

/retest

2 similar comments
@metalice
Copy link
Member Author

/retest

@upalatucci
Copy link
Member

/retest

@upalatucci
Copy link
Member

/test kubevirt-e2e-aws

@metalice metalice force-pushed the CNV-35849-make-instance-type-default branch from b41061e to 633163c Compare November 30, 2023 08:35
@openshift-ci openshift-ci bot removed the lgtm Passed code review, ready for merge label Nov 30, 2023
@upalatucci
Copy link
Member

/retest

@metalice metalice force-pushed the CNV-35849-make-instance-type-default branch from 633163c to 2cfa1c4 Compare November 30, 2023 12:21
@upalatucci
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Nov 30, 2023
@metalice metalice force-pushed the CNV-35849-make-instance-type-default branch from 2cfa1c4 to 4fe5b65 Compare November 30, 2023 13:42
@openshift-ci openshift-ci bot removed the lgtm Passed code review, ready for merge label Nov 30, 2023
@metalice metalice force-pushed the CNV-35849-make-instance-type-default branch from 4fe5b65 to 6a97af8 Compare November 30, 2023 13:48
@metalice
CNV-35849: Making instancetype default over template
875ae52 
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
@metalice metalice force-pushed the CNV-35849-make-instance-type-default branch from 6a97af8 to 875ae52 Compare November 30, 2023 14:02
@upalatucci
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Nov 30, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 30f52b7 into kubevirt-ui:main Nov 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcbailey pcbailey pcbailey left review comments

@upalatucci upalatucci upalatucci approved these changes

@avivtur avivtur Awaiting requested review from avivtur

@yaacov yaacov Awaiting requested review from yaacov

Assignees

@upalatucci upalatucci

Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@metalice @openshift-ci-robot @hstastna @upalatucci @pcbailey