Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-37480: "auto updates for RHEL VirtualMachines" is enabled by default but does not work #1741

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Jan 23, 2024

📝 Description

On a fresh cluster, the switch to allow RHEL auto updates was on by default, even if the key and id are missing, that caused the mechanism to not get the default unless you toggle it off and back on.
Allowing to set the switch on just if both id and key values are not empty after applying them is solving the issue

🎥 Demo

Before:

no-auto-update-rhel-vms.mp4

After:

no-auto-update-rhel-vms-after.mp4

…ult but does not work

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 23, 2024

@avivtur: This pull request references CNV-37480 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

On a fresh cluster, the switch to allow RHEL auto updates was on by default, even if the key and id are missing, that caused the mechanism to not get the default unless you toggle it off and back on.
Allowing to set the switch on just if both id and key values are not empty after applying them is solving the issue

🎥 Demo

Before:

no-auto-update-rhel-vms.mp4

After:

no-auto-update-rhel-vms-after.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jan 23, 2024
@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jan 23, 2024
Copy link
Contributor

openshift-ci bot commented Jan 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 74d78b9 into kubevirt-ui:main Jan 23, 2024
8 checks passed
@avivtur
Copy link
Member Author

avivtur commented Jan 23, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot
Copy link
Collaborator

@avivtur: new pull request created: #1743

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants