CNV-37517: Add routes to diagnostic tab #1744
Conversation
|
@metalice: This pull request references CNV-37517 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| urlSpitted[urlSpitted.length - 1] === 'logs' || | ||
| urlSpitted[urlSpitted.length - 1] === 'tables' |
There was a problem hiding this comment.
can you use the consts here too? VirtualMachineDetailsTab.Tables and VirtualMachineDetailsTab.Logs
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
metalice
force-pushed
the
CNV-37517-add-routes-to-diagnostic-tab
branch
from
2ec1997
to
8ef73d0
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/cherry-pick release-4.15 |
|
@gouyang: new pull request created: #1765 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
📝 Description
Adding routes to the diagnostic tab
🎥 Demo