CNV-37457: Add user provided tab to instance type #1748
Conversation
|
@metalice: This pull request references CNV-37457 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@metalice: This pull request references CNV-37457 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
It's unfortunate that the acronym for user-provided ITs is VMI since is may cause some confusion for users. |
| const UserInstancetypeList: FC = () => { | ||
| const { t } = useKubevirtTranslation(); | ||
| const [activeNamespace] = useActiveNamespace(); | ||
| const [instanceTypes, loaded, loadError] = useK8sWatchResource< |
There was a problem hiding this comment.
There's a hook for this already: useUserInstanceTypes. You can modify it to take a namespace.
There was a problem hiding this comment.
yes i know, i used it already, but this hook will fetch all except all projects, now I can edit it and add a boolean arg to it but seems redundant and less redable, because It will make branching in the hook, as there isn't any logic in this hook except the ns checking, so when using here directly usek8swatch , is same as using a custom hook, because there is no logic except the fetching.. so i didn't used the hook u recommended and directly fetched.
| <ListPageHeader | ||
| title={ | ||
| activeTabKey === 0 | ||
| ? t('VirtualMachineClusterInstancetype') |
There was a problem hiding this comment.
Why singular form used if it is a list of items we display?
u right, but should be in separate pr as this will add 9 more files to this PR |
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
metalice
force-pushed
the
CNV-37457-add-user-provided-to-instance-type
branch
from
e168612
to
a49acec
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.15 |
|
@metalice: new pull request created: #1764 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
📝 Description
🎥 Demo
After:
Before:
