CNV-23927: Do not count persistentVolumeClaim volumes in DeleteVMModal #1750
Conversation
|
@upalatucci: This pull request references CNV-23927 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
upalatucci
changed the title
|
@upalatucci: This pull request references CNV-23927 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| pvcVolumesNames: isDataVolumeGarbageCollector | ||
| ? pvcVolumesNames.concat(dvVolumesNames) | ||
| : pvcVolumesNames, | ||
| pvcVolumesNames: isDataVolumeGarbageCollector ? dvVolumesNames : [], |
There was a problem hiding this comment.
Hmm, does it still make sense to call this "pvcVolumesNames"?
There was a problem hiding this comment.
I'll propose a new thing in order to fix that.
…that will not be deleted
upalatucci
force-pushed
the
fix-delete-disks-count
branch
from
f47b904
to
06bc933
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
📝 Description
We should not count volumes that use PVC attached with
persistentVolumeClaimin the DeleteVM modal.Those volumes are attached to the VM as
existing PVCsso they do not have the same VM lifecycle.Maybe in the next version we can consider a checkbox list to let the user decide which disks wants to delete.
Demo
VM with one volume that use
persistVolumeClaimBefore
After