Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-37788: Fix instancetype link on vm details tab #1766

Conversation

metalice
Copy link
Member

📝 Description

Fixing instancetype link in VM details tab
there are 2 kinds of instance type , cluster and user.
user type need to add a namespace to it.

🎥 Demo

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 31, 2024

@metalice: This pull request references CNV-37788 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

Fixing instancetype link in VM details tab
there are 2 kinds of instance type , cluster and user.
user type need to add a namespace to it.

🎥 Demo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jan 31, 2024
@metalice metalice force-pushed the CNV-37788-fix-instance-type-link branch from f28b870 to 37c6504 Compare January 31, 2024 11:39
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
@metalice metalice force-pushed the CNV-37788-fix-instance-type-link branch from 37c6504 to e853017 Compare January 31, 2024 11:50
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jan 31, 2024
Copy link
Contributor

openshift-ci bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@avivtur
Copy link
Member

avivtur commented Jan 31, 2024

/retest

1 similar comment
@upalatucci
Copy link
Member

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit b7da736 into kubevirt-ui:main Jan 31, 2024
9 checks passed
@gouyang
Copy link
Member

gouyang commented Feb 2, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot
Copy link
Collaborator

@gouyang: new pull request created: #1774

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants