-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-37788: Fix instancetype link on vm details tab #1766
CNV-37788: Fix instancetype link on vm details tab #1766
Conversation
@metalice: This pull request references CNV-37788 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
f28b870
to
37c6504
Compare
...overview/components/VirtualMachinesOverviewTabDetails/components/InstanceTypeDescription.tsx
Outdated
Show resolved
Hide resolved
...overview/components/VirtualMachinesOverviewTabDetails/components/InstanceTypeDescription.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
37c6504
to
e853017
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
/cherry-pick release-4.15 |
@gouyang: new pull request created: #1774 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
📝 Description
Fixing instancetype link in VM details tab
there are 2 kinds of instance type , cluster and user.
user type need to add a namespace to it.
🎥 Demo