Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-37857: Enable SSH secret selection on quick create flow #1780

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Feb 5, 2024

📝 Description

Allowing to select a secret for SSH on VM quick create flow.

🎥 Demo

After:

ssh-quick-create2
ssh-quick-create

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 5, 2024

@avivtur: This pull request references CNV-37857 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "CNV v4.15.0" instead.

In response to this:

📝 Description

Allowing to select a secret for SSH on VM quick create flow.

🎥 Demo

After:

ssh-quick-create2
ssh-quick-create

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Feb 5, 2024
Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@metalice
Copy link
Member

/lgtm
/hold until routes merges

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Feb 14, 2024
Copy link
Contributor

openshift-ci bot commented Feb 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metalice
Copy link
Member

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit bb483d1 into kubevirt-ui:main Feb 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants