Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-37575: Add save button to the environment sidebar editor #1788

Merged

Conversation

upalatucci
Copy link
Member

@upalatucci upalatucci commented Feb 12, 2024

📝 Description

The issue is related to the onEditChange={setDisableVmCreate}

This callback should disable the Create button in the wizard but this the trigger a re-loading.
I would remove that behaviour at this point as we do not do that in other tabs.

the sidebar editor triggers a VM update at the beginning and everytime we change something in the editor.
Instead of using onChange we should use onResourceUpdate. It will show the Save button on the bottom like in all the other tabs. Clicking on the save button will trigger the reloading of the EnvironmentForm.

🎥 Demo

Screenshot from 2024-02-12 16-04-21

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Feb 12, 2024
@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Feb 14, 2024
Copy link
Contributor

openshift-ci bot commented Feb 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@upalatucci
Copy link
Member Author

/retest

2 similar comments
@metalice
Copy link
Member

/retest

@upalatucci
Copy link
Member Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit d540bac into kubevirt-ui:main Feb 15, 2024
9 checks passed
@upalatucci upalatucci changed the title Add save button to the environment sidebar editor CNV-37575: Add save button to the environment sidebar editor Feb 20, 2024
@upalatucci
Copy link
Member Author

/jira refresh

@gouyang
Copy link
Member

gouyang commented Mar 7, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot
Copy link
Collaborator

@gouyang: new pull request created: #1829

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants