Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Template's Disks title margin prop #1790

Merged

Conversation

hstastna
Copy link

📝 Description

Fix broken/not applied css margin prop for Template Disks page title so the title looks the same as in the other Template tabs. This got probably broken during some refactoring or other related changes of the page/DiskListTitle component.

🎥 Screenshots

Before:
Title of the page too close to the upper border of the page:
disks_before

After:
More space around the title, same as in other VM Template's tabs/pages:
disks_after

Fix broken/not applied css margin prop for Template Disks page title
so the title looks the same as in the other Template tabs.
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Feb 12, 2024
@hstastna
Copy link
Author

@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review

@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Feb 12, 2024
Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5a48604 into kubevirt-ui:main Feb 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants