Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-34180: fetch user accessible hyperconverge config resource #1794

Merged

Conversation

upalatucci
Copy link
Member

@upalatucci upalatucci commented Feb 14, 2024

📝 Description

Regular users cannot access Hyperconverge configuration.
in order to fix this bug we have to fetch the new Kubevirt Hyperconverge configuration made exactly for that

🎥 Demo

Screenshot from 2024-02-14 12-01-51

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 14, 2024

@upalatucci: This pull request references CNV-34180 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

Regular users cannot access Hyperconverge configuration.
in order to fix this bug we have to fetch the new Kubevirt Hyperconverge configuration made exactly to fix this issue

🎥 Demo

Screenshot from 2024-02-14 12-01-51

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Feb 14, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 14, 2024

@upalatucci: This pull request references CNV-34180 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

Regular users cannot access Hyperconverge configuration.
in order to fix this bug we have to fetch the new Kubevirt Hyperconverge configuration made exactly for that

🎥 Demo

Screenshot from 2024-02-14 12-01-51

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@upalatucci upalatucci force-pushed the fix-hyperconver-config-fetch branch 2 times, most recently from 5de6cd4 to 0d3be1a Compare February 14, 2024 13:13
@upalatucci
Copy link
Member Author

/retest

@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Feb 18, 2024
Copy link
Contributor

openshift-ci bot commented Feb 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e75f676 into kubevirt-ui:main Feb 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants