Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-38404: search with / does not work #1799

Merged

Conversation

upalatucci
Copy link
Member

@upalatucci upalatucci commented Feb 15, 2024

📝 Description

When the user press / we make focus on the search input. Like in other pages.

Bug: when the input is already in focus and the user type /, the handler prevent the typing.

Fix: do not preventDefault when the input is in focus

Demo
image

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 15, 2024

@upalatucci: This pull request references CNV-38404 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

When the user press / we make focus on the search input. Like in other pages.

Bug: when the input is already in focus and the user type /, the handler prevent the typing.

Fix: do not preventDefault when the input is in focus

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Feb 15, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 15, 2024

@upalatucci: This pull request references CNV-38404 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

When the user press / we make focus on the search input. Like in other pages.

Bug: when the input is already in focus and the user type /, the handler prevent the typing.

Fix: do not preventDefault when the input is in focus

Demo
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Feb 15, 2024
Copy link
Contributor

openshift-ci bot commented Feb 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hstastna,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@upalatucci
Copy link
Member Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 8e2ab2e into kubevirt-ui:main Feb 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants