Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-38450: Display VM Console tab as expected #1806

Conversation

hstastna
Copy link

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-38450

Prevent the VM Console tab crashing if cloudInitNoCloud user's password is a number.

🎥 Screenshots

Before:
cl_before

After:
cl_after

Prevent the VM Console tab crashing if cloudInitNoCloud user's password
is a number.

Fixes https://issues.redhat.com/browse/CNV-38450
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 19, 2024

@hstastna: This pull request references CNV-38450 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-38450

Prevent the VM Console tab crashing if cloudInitNoCloud user's password is a number.

🎥 Screenshots

Before:
cl_before

After:
cl_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Feb 19, 2024
@hstastna
Copy link
Author

@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review

@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Feb 19, 2024
Copy link
Contributor

openshift-ci bot commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ee28f85 into kubevirt-ui:main Feb 19, 2024
9 checks passed
@gouyang
Copy link
Member

gouyang commented Apr 10, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot
Copy link
Collaborator

@gouyang: new pull request created: #1876

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants