Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-32929: Correct resource badge for user-created VM InstanceTypes in Add boot volume modal #1810

Conversation

pcbailey
Copy link
Member

📝 Description

A side effect from #1803 caused user-created VM InstanceTypes to be displayed in the Add boot volume modal, but the resource badge used is for VirtualMachineClusterInstanceTypes. This PR corrects that behavior and directly fixes the issue created by the side effect to ensure a regression doesn't happen in the future.

Jira: https://issues.redhat.com/browse/CNV-32929

🎥 Screenshots

Before

show-user-created-vm-its-add-volume-modal-BEFORE-2024-02-20_12-05

After

show-user-created-vm-its-add-volume-modal-AFTER-2024-02-20_12-02

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 21, 2024

@pcbailey: This pull request references CNV-32929 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

A side effect from #1803 caused user-created VM InstanceTypes to be displayed in the Add boot volume modal, but the resource badge used is for VirtualMachineClusterInstanceTypes. This PR corrects that behavior and directly fixes the issue created by the side effect to ensure a regression doesn't happen in the future.

Jira: https://issues.redhat.com/browse/CNV-32929

🎥 Screenshots

Before

show-user-created-vm-its-add-volume-modal-BEFORE-2024-02-20_12-05

After

show-user-created-vm-its-add-volume-modal-AFTER-2024-02-20_12-02

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Feb 21, 2024
@pcbailey pcbailey force-pushed the bug-show-user-created-vm-it-boot-volume-modal branch from 3a040d2 to 441846f Compare February 21, 2024 13:45
@pcbailey pcbailey force-pushed the bug-show-user-created-vm-it-boot-volume-modal branch from 441846f to 232108c Compare February 26, 2024 16:29
@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Feb 28, 2024
Copy link
Contributor

openshift-ci bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3b97fb1 into kubevirt-ui:main Feb 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants