-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-38360: Fix NIC hot-unplug alert message #1811
CNV-38360: Fix NIC hot-unplug alert message #1811
Conversation
@pcbailey: This pull request references CNV-38360 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, pcbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/cherry-pick release-4.15 |
/cherry-pick release-4.14 |
@gouyang: new pull request created: #1854 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@gouyang: #1811 failed to apply on top of branch "release-4.14":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
📝 Description
This PR fixes the alert message shown when a NIC is deleted as well as the logic dictating when the alert is shown. The alert is to be shown only when a hot-plug NIC is being deleted while the VM is running.
Jira: https://issues.redhat.com/browse/CNV-38360
🎥 Screenshots
Before
Hot-plug NIC
Default NIC
After
Hot-plug NIC
Default NIC