Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-37814: Fix UI glitches from PFv5 #1813

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Feb 26, 2024

📝 Description

Fixing issues from the upgrade to PFv5 according to this document:
https://docs.google.com/spreadsheets/d/1WpnJnw4FcfG1xvk1QKdK1l9de33Qtc-al2mQl5J2CQU/edit#gid=1386834576

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Feb 26, 2024
@hstastna
Copy link

/retest

@hstastna
Copy link

hstastna commented Feb 26, 2024

Hi @avivtur could you, please, mention explicitly which of the glitches this PR fixes? It would help us to review and test this PR much faster. Thanks! :)

@avivtur avivtur changed the title Fix UI glitches from PFv5 [WIP] Fix UI glitches from PFv5 Feb 28, 2024
@avivtur
Copy link
Member Author

avivtur commented Feb 28, 2024

Hi @avivtur could you, please, mention explicitly which of the glitches this PR fixes? It would help us to review and test this PR much faster. Thanks! :)

Hi @hstastna
You can take a look at the doc added in the description and see in main branch the glitches, and compare it to this branch as there are many changes

@avivtur avivtur force-pushed the fix-glitches-pfv5 branch 4 times, most recently from 714624d to 8921f1b Compare February 28, 2024 20:01
Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@avivtur avivtur changed the title [WIP] Fix UI glitches from PFv5 Fix UI glitches from PFv5 Feb 29, 2024
@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Feb 29, 2024
Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@avivtur avivtur changed the title Fix UI glitches from PFv5 CNV-37814: Fix UI glitches from PFv5 Feb 29, 2024
@avivtur
Copy link
Member Author

avivtur commented Feb 29, 2024

/jira refresh

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 29, 2024

@avivtur: This pull request references CNV-37814 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit a7c3df0 into kubevirt-ui:main Feb 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants