Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNV-37815: Refactor SSH modal #1817

Merged
merged 1 commit into from
Mar 7, 2024
Merged

CNV-37815: Refactor SSH modal #1817

merged 1 commit into from
Mar 7, 2024

Conversation

pcbailey
Copy link
Member

@pcbailey pcbailey commented Mar 3, 2024

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 3, 2024 •
edited by openshift-ci bot
Loading

@pcbailey: This pull request references CNV-37815 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

jira: https://issues.redhat.com/browse/CNV-37815

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from hstastna and tnisan March 3, 2024 02:10
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Mar 3, 2024
@pcbailey pcbailey force-pushed the refactor-ssh-modal branch 2 times, most recently from 0bd4e3f to 756643b Compare March 7, 2024 14:49
@pcbailey pcbailey changed the title WIP: CNV-37815: Refactor SSH modal CNV-37815: Refactor SSH modal Mar 7, 2024
@metalice
Copy link
Member

metalice commented Mar 7, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Mar 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ac88c27 into kubevirt-ui:main Mar 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalice metalice metalice left review comments

@hstastna hstastna Awaiting requested review from hstastna

@tnisan tnisan Awaiting requested review from tnisan

Assignees

@metalice metalice

Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcbailey @openshift-ci-robot @metalice