CNV-37609: Remove unnecessary type selection #1834
Conversation
|
@avivtur: This pull request references CNV-37609 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@avivtur: This pull request references CNV-37609 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
src/utils/components/NetworkInterfaceModal/components/NetworkInterfaceNetworkSelect.tsx
Outdated
Show resolved
Hide resolved
|
/hold |
avivtur
force-pushed
the
remove-type-dropdown-network-modal
branch
from
d88aaf5
to
eddcad1
Compare
|
/unhold |
| </FormGroupHelperText> | ||
| {loaded && ( | ||
| <FormGroupHelperText validated={validated}> | ||
| {validated === ValidatedOptions.error && |
There was a problem hiding this comment.
move it next to loading? as i will render and empty div
| @@ -1,19 +1,35 @@ | |||
| import React, { Dispatch, FC, MouseEvent, SetStateAction, useEffect, useMemo } from 'react'; | |||
| import { Trans } from 'react-i18next'; | |||
There was a problem hiding this comment.
please break this file to small pieces, its getting too big
There was a problem hiding this comment.
Moved the popover icon component outside
Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
avivtur
force-pushed
the
remove-type-dropdown-network-modal
branch
from
eddcad1
to
88ef501
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, hstastna, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
Since we can get the type of network binding from the NAD, we can remove the type selection as it's not needed.
UX doc
🎥 Demo
Before:
After:
