Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-38331: Changing snapshot actions and modals text #1838

Conversation

metalice
Copy link
Member

📝 Description

Changing text of snapshot actions and modals

🎥 Demo

After:
image

image

image

image

Before:
image

image

image

image

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 10, 2024

@metalice: This pull request references CNV-38331 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

Changing text of snapshot actions and modals

🎥 Demo

After:
image

image

image

image

Before:
image

image

image

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from pcbailey and yaacov March 10, 2024 06:13
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Mar 10, 2024
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
@metalice metalice force-pushed the CNV-38331-change-snapshot-actions-and-modals-text- branch from e9d2d4b to d63b7fa Compare March 12, 2024 09:20
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Mar 12, 2024
Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5b6a53f into kubevirt-ui:main Mar 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants