Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose qemu machine type read-only in VM/Template Details tab #669

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Expose qemu machine type read-only in VM/Template Details tab #669

merged 1 commit into from
Jun 27, 2022

Conversation

hstastna
Copy link

@hstastna hstastna commented Jun 24, 2022 •
edited
Loading

📝 Description

Display qemu machine type in the VM/Template Details tab, the field is not editable.

Related upstream doc:
https://kubevirt.io/user-guide/virtual_machines/virtual_hardware/#machine-type

Issue:
https://issues.redhat.com/browse/CNV-12598

🎥 Demo

Machine type field in the VM Details tab:
machine1
Machine type field in the VM Template's Details tab:
machine2

@yaacov yaacov changed the title [WIP] Expose qemu machine type read-only in VM Details tab Expose qemu machine type read-only in VM Details tab Jun 26, 2022
@yaacov
Copy link
Contributor

yaacov commented Jun 26, 2022

/approve

a - should be near "boot mode" and "cpu / meme" (like cpu, mem and boot mode it describe the virtulization h/w)
( maybe even create a section for h/w section and put the devices and "boot order" too )
b - should also be in templates, wizard and vmis views

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jun 26, 2022
@tnisan
Copy link
Member

tnisan commented Jun 27, 2022

Between the CPU and Boot Mode is ideal imo

@hstastna hstastna closed this Jun 27, 2022
@openshift-ci openshift-ci bot removed the approved This issue is something we want to fix label Jun 27, 2022
@hstastna hstastna reopened this Jun 27, 2022
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jun 27, 2022
@yaacov
Copy link
Contributor

yaacov commented Jun 27, 2022

/lgtm

p.s.
we can also add it in the wizard

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jun 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit ff248ff into kubevirt-ui:main Jun 27, 2022
@hstastna
Copy link
Author

Note that adding Machine type to the wizard and also to the VMI Details tab will be done in followup PRs.

@hstastna hstastna changed the title Expose qemu machine type read-only in VM Details tab Expose qemu machine type read-only in VM/Template Details tab Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnisan tnisan Awaiting requested review from tnisan

@vojtechszocs vojtechszocs Awaiting requested review from vojtechszocs

Assignees

@yaacov yaacov

Labels
approved This issue is something we want to fix lgtm Passed code review, ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hstastna @yaacov @tnisan