-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2101628: DataSource selection with parameter #688
Bug 2101628: DataSource selection with parameter #688
Conversation
Skipping CI for Draft Pull Request. |
@upalatucci: This pull request references Bugzilla bug 2101628, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@upalatucci: This pull request references Bugzilla bug 2101628, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
...ents/DiskModal/DiskFormFields/DiskSourceFormSelect/components/DiskSourceDataSourceSelect.tsx
Outdated
Show resolved
Hide resolved
dfc99ce
to
928b166
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: upalatucci, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@upalatucci: All pull requests linked via external trackers have merged: Bugzilla bug 2101628 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
📝 Description
Cause
Data source project value is a parameter so cannot load data sources
Solution
Disable the data source selection when the project is a parameter and display the data source select when is disabled without waiting to load other data sources.
🎥 Demo