Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2101628: DataSource selection with parameter #688

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

upalatucci
Copy link
Member

@upalatucci upalatucci commented Jun 29, 2022

📝 Description

Cause
Data source project value is a parameter so cannot load data sources

Solution
Disable the data source selection when the project is a parameter and display the data source select when is disabled without waiting to load other data sources.

🎥 Demo

Screenshot from 2022-06-29 13-28-33

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2022

@upalatucci: This pull request references Bugzilla bug 2101628, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2101628: DataSource selection with parameter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2022

@upalatucci: This pull request references Bugzilla bug 2101628, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2101628: DataSource selection with parameter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yaacov
Copy link
Contributor

yaacov commented Jun 30, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jun 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upalatucci, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jun 30, 2022
@openshift-ci openshift-ci bot merged commit 41d725e into kubevirt-ui:main Jun 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2022

@upalatucci: All pull requests linked via external trackers have merged:

Bugzilla bug 2101628 has been moved to the MODIFIED state.

In response to this:

Bug 2101628: DataSource selection with parameter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-medium bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants