Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2101667: Move VMI Scheduling section to a new tab #695

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

hstastna
Copy link

📝 Description

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2101667

Move the VirtualMachineInstance Scheduling and resources requirements section from the Details tab to the new Scheduling tab, to achieve consistency with VM/Templates pages.

🎥 Demo

Before:
VMI Scheduling and resources requirements section in the Details tab:
sched-before
After:
A separate new Scheduling tab:
sched-after2
Scheduling and resources requirements section not present in the Details tab anymore:
sched-after1

Move the VirtualMachineInstance 'Scheduling and resources requirements'
section from the 'Details' tab to a new 'Scheduling' tab, to achieve
consistency with VM/Templates pages.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2101667
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2022

@hstastna: This pull request references Bugzilla bug 2101667, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2101667: Move VMI Scheduling section to a new tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hstastna
Copy link
Author

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2022

@avivtur: This pull request references Bugzilla bug 2101667, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@avivtur
Copy link
Member

avivtur commented Jun 29, 2022

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2022

@avivtur: This pull request references Bugzilla bug 2101667, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gouyang June 29, 2022 15:11
@avivtur
Copy link
Member

avivtur commented Jun 29, 2022

/lgtm
🥇 🥇

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jun 29, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, hstastna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jun 29, 2022
@openshift-ci openshift-ci bot merged commit 4007c86 into kubevirt-ui:main Jun 29, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2022

@hstastna: All pull requests linked via external trackers have merged:

Bugzilla bug 2101667 has been moved to the MODIFIED state.

In response to this:

Bug 2101667: Move VMI Scheduling section to a new tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-medium bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants