-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2101667: Move VMI Scheduling section to a new tab #695
Bug 2101667: Move VMI Scheduling section to a new tab #695
Conversation
Move the VirtualMachineInstance 'Scheduling and resources requirements' section from the 'Details' tab to a new 'Scheduling' tab, to achieve consistency with VM/Templates pages. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2101667
@hstastna: This pull request references Bugzilla bug 2101667, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@avivtur: This pull request references Bugzilla bug 2101667, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@avivtur: This pull request references Bugzilla bug 2101667, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, hstastna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@hstastna: All pull requests linked via external trackers have merged: Bugzilla bug 2101667 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
📝 Description
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2101667
Move the VirtualMachineInstance Scheduling and resources requirements section from the Details tab to the new Scheduling tab, to achieve consistency with VM/Templates pages.
🎥 Demo
Before:
VMI Scheduling and resources requirements section in the Details tab:
After:
A separate new Scheduling tab:
Scheduling and resources requirements section not present in the Details tab anymore: