Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2101454: cant load PVCs for non-priv user #709

Merged

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Jun 30, 2022

📝 Description

this fix includes:

  • fetching the PVCs data from each namespace instead of fetching for 'all-namespaces'
  • When a non priv user is trying to change a boot source reference for a DataSource that points to a PVC in a namespace where the user has no permissions to re-create the PVC, it will fail, so disabled this action in case the user can not re-create the PVC in the same namespace the older PVC was

🎥 Demo

before:

edit-boot-source-ref-before-pvc-stuck

after:

edit_boot_source_pvc_stuck_loading-after.mp4

Signed-off-by: Aviv Turgeman aturgema@redhat.com

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2022

@avivtur: This pull request references Bugzilla bug 2101454, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2101454: cant load PVCs for non-priv user

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gouyang June 30, 2022 16:34
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jun 30, 2022
Copy link
Member

@upalatucci upalatucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :-)

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jul 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@avivtur
Copy link
Member Author

avivtur commented Jul 4, 2022

/retest

@openshift-ci openshift-ci bot merged commit 3036098 into kubevirt-ui:main Jul 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 4, 2022

@avivtur: All pull requests linked via external trackers have merged:

Bugzilla bug 2101454 has been moved to the MODIFIED state.

In response to this:

Bug 2101454: cant load PVCs for non-priv user

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@avivtur
Copy link
Member Author

avivtur commented Jul 4, 2022

/cherry-pick release-4.11

@openshift-cherrypick-robot
Copy link
Collaborator

@avivtur: new pull request created: #726

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-high bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants