Bug 2101335: Clone action enabled for CrashLoopBackOff #738
Conversation
|
@glekner: This pull request references Bugzilla bug 2101335, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
1 similar comment
|
/lgtm |
There was a problem hiding this comment.
Looks like the fix does not include other error-like states. What about them? There is the additional info in the BZ:
Additional info: Also reproduced with other error states like ErrImagePull or ImagePullBackOff.
Seems to me that there may be more states we should take care of. Maybe it would be good to check/include all possible error-like states. If there are too many such states, maybe it worth to fix this the opposite way: to create an array with the states that are okay for cloning and then to check if the actual state is in that array. And if not, then to disable cloning.
| @@ -21,6 +21,7 @@ export const printableVMStatus = { | |||
| Terminating: 'Terminating', | |||
| Failed: 'Failed', | |||
| Unknown: 'Unknown', | |||
| CrashLoopBackOff: 'CrashLoopBackOff', | |||
There was a problem hiding this comment.
This will add a new filter in the VM list
I suggest to filter it here or creating a different array/object for the filters
There was a problem hiding this comment.
@upalatucci @hstastna thanks, ill take a look
|
@avivtur @upalatucci @hstastna please note all the possible vm statuses here I fixed |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, glekner, metalice, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@glekner: All pull requests linked via external trackers have merged: Bugzilla bug 2101335 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
📝 Description
🎥 Demo