Bug 2102074: Improve VM Creation time on VM Overview Details card

[hstastna]

📝 Description

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2102074

Add "ago" and plural form to VM creation time string to be grammatically correct.

🎥 Demo

Before:
Singular and without "ago":

After:

[openshift-ci]

@hstastna: This pull request references Bugzilla bug 2102074, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lkladnit

In response to this:

Bug 2102074: Improve VM Creation time on VM Overview Details card

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: lkladnit.

Note that only kubevirt-ui members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@hstastna: This pull request references Bugzilla bug 2102074, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lkladnit

In response to this:

Bug 2102074: Improve VM Creation time on VM Overview Details card

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@hstastna: This pull request references Bugzilla bug 2102074, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lkladnit

In response to this:

Bug 2102074: Improve VM Creation time on VM Overview Details card

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: lkladnit.

Note that only kubevirt-ui members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@hstastna: This pull request references Bugzilla bug 2102074, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lkladnit

In response to this:

Bug 2102074: Improve VM Creation time on VM Overview Details card

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hstastna]

@glekner @avivtur @metalice @pcbailey @yzamir @vojtechszocs please review

[metalice]

Hi @hstastna I think other components are using Timestamp component. Can you please check? if needed add this fix to other places where needed? So everything will be on same schema of timing with pluriliza.

[hstastna]

@metalice I've checked that and the Timestamp component usually displays the date+time, when something was created. Here it is different: it does not show when it was created, but how many minutes/hours/days ago it was created. Due to omitSuffix option. I've checked that other places that use Timestamp component, have this option already set to false.

[metalice]

Cool 👍

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [metalice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@hstastna: All pull requests linked via external trackers have merged:

• kubevirt-ui/kubevirt-plugin#747

Bugzilla bug 2102074 has been moved to the MODIFIED state.

In response to this:

Bug 2102074: Improve VM Creation time on VM Overview Details card

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.