CNV-19414: Templates project tab #753
Conversation
metalice
force-pushed
the
CNV-19414-templates-projects-tab
branch
4 times, most recently
from
61bf50a
to
db10846
Compare
metalice
changed the title
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
metalice
force-pushed
the
CNV-19414-templates-projects-tab
branch
from
db10846
to
cdc13dd
Compare
| isDisabled={isEmpty(name)} | ||
| > | ||
| <Text> | ||
| {t('An OpenShift project is an alternative representation of a Kubernetes namespace.')} |
There was a problem hiding this comment.
I think we can simply omit the 'An' at the beginning
| <Popover | ||
| bodyContent={ | ||
| <Trans t={t} ns="plugin__kubevirt-plugin"> | ||
| A Project name must consist of lower case alphanumeric characters or ', and |
There was a problem hiding this comment.
I think we can omit the 'A' at the beginning
| { | ||
| op: 'replace', | ||
| path: `/spec/commonTemplatesNamespace`, | ||
| value: newNamespace === OPENSHIFT ? null : newNamespace, |
There was a problem hiding this comment.
why do you need to check here if the newNamespace is openshift? what will happen if we changed it once from openshift to some other namespace and than I want to change it back? won't we lose all templates?
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Matan Schatzman mschatzm@redhat.com
📝 Description
Adding template project tab - this gives the user option to move common templates from one name space to another.
🎥 Demo