Bug 2143216: Template with no edit permission #978
Conversation
|
@upalatucci: This pull request references Bugzilla bug 2143216, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@upalatucci: This pull request references Bugzilla bug 2143216, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
upalatucci
force-pushed
the
no-permission-template
branch
from
dac217d
to
5edac36
Compare
upalatucci
force-pushed
the
no-permission-template
branch
from
5edac36
to
e2c63fa
Compare
| // t('Can not edit in view-only mode') | ||
| export const NO_EDIT_TEMPLATE_PERMISSIONS = 'Can not edit in view-only mode'; | ||
|
|
||
| // t('You do not have permission to delete. To make changes to this template, contact your administrator.') | ||
| export const NO_DELETE_TEMPLATE_PERMISSIONS = | ||
| 'You do not have permission to delete. To make changes to this template, contact your administrator.'; | ||
| // t('Can not delete in view-only mode') | ||
| export const NO_DELETE_TEMPLATE_PERMISSIONS = 'Can not delete in view-only mode'; |
There was a problem hiding this comment.
it doesn't seem these constants are being used, if not can they be used, or if not needed then removed?
There was a problem hiding this comment.
delete is used only one time and edit a couple of times in this file here src/view/templates/actions/hooks/useVirtualMachimeTemplatesActions.tsx
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@upalatucci: All pull requests linked via external trackers have merged: Bugzilla bug 2143216 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
📝 Description
Template view-mode message updated.
Do not use buttons with tooltips.
Just use the header alert
🎥 Demo