Bug 2148849: Make help text links work, in VM & DataSource details pages #989
Conversation
|
@hstastna: This pull request references Bugzilla bug 2148849, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review |
| @@ -37,15 +36,17 @@ export const DescriptionItemHeader: React.FC<DescriptionItemHeaderProps> = ({ | |||
| {moreInfoURL && ( | |||
| <> | |||
| {t('More info: ')} | |||
| <Link to={moreInfoURL}>{moreInfoURL}</Link> | |||
| <a href={moreInfoURL}>{moreInfoURL}</a> | |||
There was a problem hiding this comment.
Because Link does not work as we would expect. It "looks" at the history. That's not what we want in here.
Also because everywhere where this works without issues, we already use a element exactly like this. It's so simple that it doesn't worth to create a new React element, IMO.
src/views/templates/details/tabs/details/components/TemplateDetailsLeftGrid.tsx
Outdated
Show resolved
Hide resolved
...ails/tabs/details/components/VirtualMachineDescriptionItem/VirtualMachineDescriptionItem.tsx
Outdated
Show resolved
Hide resolved
hstastna
force-pushed
the
BZ_Help_text_DataSource_details_incorrect_url
branch
from
2519b0b
to
28366e1
Compare
Redirect to proper websites when clicking on the help/popover text links, in VM and DataSource Details tabs. Improve the design, incorrect aligning of the text, breadcrumbs, in those popovers. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2148849
hstastna
force-pushed
the
BZ_Help_text_DataSource_details_incorrect_url
branch
from
28366e1
to
35ee200
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hstastna, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@hstastna: All pull requests linked via external trackers have merged: Bugzilla bug 2148849 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
📝 Description
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2148849
Redirect to proper websites when clicking on the help/popover text links, in VM and DataSource Details tabs.
Improve the design, incorrect aligning of the text, breadcrumbs, in those popovers.
🎥 Screenshots
Before:
Clicking on Labels title displays the help text that does not look good + the link does not work:
After clicking on the link from the popover text:
After:
After clicking on the link from the popover text, the correct website is loaded: