CNV-22029: Adding the option to edit the Hostname #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avivtur
reviewed
Dec 6, 2022
| value={newHostname} | ||
| type="text" | ||
| id={'cloudinit-hostname'} | ||
| onChange={(v) => setHostname(v)} |
There was a problem hiding this comment.
can be simply onChange={setHostname}
| isOpen={isOpen} | ||
| onClose={onClose} | ||
| onSubmit={onSubmit} | ||
| headerText={'Hostname'} |
There was a problem hiding this comment.
please change to headerText={t('Edit hostname')}
DanaOrr
force-pushed
the
remove-hostname-field
branch
2 times, most recently
from
c2e9e3a
to
69c743c
Compare
Signed-off-by: Dana Orr <dorr@redhat.com>
DanaOrr
force-pushed
the
remove-hostname-field
branch
from
69c743c
to
8a6efa2
Compare
avivtur
approved these changes
Dec 7, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, DanaOrr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dana Orr dorr@redhat.com
📝 Description
🎥 Demo
Removing the hostname field in the Cloud-init form
Before:
After:
Adding the option to edit the hostname on the details page:
Adding the hostname field to the Review and create VirtualMachine page:
